Repository navigation
Open
Conversation
satyakigh
added this pull request to stack #701
October 7, 2026 20:03
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/vitestThe overall line coverage in commit ec4c039 in the Show a line coverage summary of the most impacted files.
Updated |
satyakigh
dismissed
mrinaudo-aws’s stale review
October 9, 2026 21:44
The merge-base changed after approval.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change addresses two production reliability issues:
cloudformation-validatein a bounded worker thread so expensive validation cannot block or exhaust the language-server process.Datastore cleanup
FileDB and LMDB persist data in versioned directories (
filedb/v4andlmdb/v7). Cleanup previously removed older directories without accounting for another IDE window or language-server process still using that version, which caused thefiles.scan.errorspike during the FileDB v3-to-v4 migration.The updated implementation:
.heartbeatin the active FileDB or LMDB version directory at startup and refreshes it every 60 seconds.filedb.oldVersion.cleanup.*andlmdb.oldVersion.cleanup.*metrics.cloudformation-validateisolationLarge templates with many conditional (
Fn::If) properties could exhaust the validation engine's memory. Because the engine ran on the main thread, a large validation could freeze the language server and leave subsequent validations failing.The validation engine now:
Worker and retry failures now use typed errors (
WorkerExitError,WorkerFailureError,WorkerShutdownError, andRetryError) while preserving the existing user-facing messages. Error mapping recognizes the new worker failures, and the cfn-lint worker uses the same typed worker errors.Supporting changes
Validation
npm run buildnpm run lintnpm run test— 299 test files passed; 5,039 tests passed and 3 skippedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.